Skip to content

GCC package profiles do not set LD_LIBRARY_PATH #193

Closed
pmenzel opened this issue May 14, 2022 · 3 comments
Closed

GCC package profiles do not set LD_LIBRARY_PATH #193

pmenzel opened this issue May 14, 2022 · 3 comments

Comments

@pmenzel
Copy link
Contributor

pmenzel commented May 14, 2022

GCC:

cat >$PREFIX/profile <<-EOF
PATH=$PREFIX/bin:\$PATH
if [ -d $PREFIX/.compatlibs ]; then export LD_LIBRARY_PATH=$PREFIX/.compatlibs\${LD_LIBRARY_PATH:+:\$LD_LIBRARY_PATH} ; fi
EOF

LLVM:

cat >$PREFIX/profile <<-EOF
PATH=$PREFIX/bin:\$PATH
export LD_LIBRARY_PATH=$PREFIX/lib\${LD_LIBRARY_PATH:+:\$LD_LIBRARY_PATH}
if [ -d $PREFIX/.compatlibs ]; then export LD_LIBRARY_PATH=$PREFIX/.compatlibs\${LD_LIBRARY_PATH:+:\$LD_LIBRARY_PATH} ; fi
EOF

pmenzel added a commit that referenced this issue May 14, 2022
The build currently fails with the GCC 11.1.0 package, [as its profile
does not set `LD_LIBRARY_PATH`][1].

[1]: #193
@pmenzel
Copy link
Contributor Author

pmenzel commented May 14, 2022

I always forget the rules, if editing profiles is allowed or not.

@donald
Copy link
Contributor

donald commented May 14, 2022

"The Pirate Code is more what you call guidelines than actual rules"

In fact, if all C+ compiled programs will trigger the automount of the gcc package they were build with, we should avoid to have to many of those. So maybe in this case...

@pmenzel
Copy link
Contributor Author

pmenzel commented May 23, 2022

I edited all the profiles besides gcc-5.5.0-1, already containing that line.

@ellie:/amd/ellie/1/package/pkg$ sudo vim gcc*/profile

pmenzel added a commit that referenced this issue May 23, 2022
C++ programs often need the libraries, so add them to the profile.
LLVM/clang already does that.

The existing profiles have been updated after the build, so also add the
line to the build script of the newest GCC release in the tree, so it’
won’t be forgotten.

Resolves: #193
pmenzel added a commit that referenced this issue May 23, 2022
The build currently fails with the GCC 11.1.0 package, [as its profile
does not set `LD_LIBRARY_PATH`][1].

[1]: #193
@niclas niclas closed this as completed Sep 21, 2022
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants