build script exit status ignored by tools/build.sh #72

donald · 2019-07-01T14:03:30Z

Since #66 the exist status of the build script is lost, because script dosn't forward the exist status:

buczek@theinternet:~/git/pkg-scripts (fix-build-log)$ script -q -c "false" x.log ; echo $?
0

So tools/build.sh now continues even if the build scripts fails. Bad.

The fact, that the logfile is now written by the build user instead of the calling user is another unintentional change of #66.

The text was updated successfully, but these errors were encountered:

thomas · 2019-07-15T13:03:47Z

Completely agree on this. Changing a failed build to bin.bin is not clever.

'script -e' returns the exit code of the child process. This yields again to the intended behaviour (Closes #72).

thomas added a commit that referenced this issue Aug 1, 2019

build.sh: Let script cmd return exit code

3555f8a

'script -e' returns the exit code of the child process. This yields again to the intended behaviour (Closes #72).

thomas mentioned this issue Aug 1, 2019

build.sh: Let script cmd return exit code #77

Merged

donald closed this as completed in #77 Aug 1, 2019

build script exit status ignored by tools/build.sh #72

build script exit status ignored by tools/build.sh #72

donald commented Jul 1, 2019

thomas commented Jul 15, 2019

build script exit status ignored by tools/build.sh #72

build script exit status ignored by tools/build.sh #72

Comments

donald commented Jul 1, 2019

thomas commented Jul 15, 2019