Skip to content

build.sh: check folder permissions, not mountpoint-destination #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wwwutz
Copy link
Contributor

@wwwutz wwwutz commented Mar 3, 2021

  • circumvent rare race condition on initial mount

  • modify tools/build.sh

- circumvent rare race condition on initial mount
@donald
Copy link
Contributor

donald commented Mar 3, 2021

I don't mind the "/." but are you sure there can be a race? The stat is supposed to wait AFAIK.

@wwwutz
Copy link
Contributor Author

wwwutz commented Mar 3, 2021

well I discovered twice something like an existing /pkg/bla-foo-1.0.02 pointing nowhere for a fraction of a second. maybe some automounter issue. Maybe the automounter adds the entry just before mounting. As said: rare. But seen quite often in the wild. Maybe due to umount /pkg/brave-browser-1.20.103-0 ;./tools/build.sh bravebla... repeating a lot in the dev cycle.

@thomas
Copy link
Contributor

thomas commented Mar 3, 2021

So you have stumbled over your own procedure. Hmm, what about being a coward, and add a short sleep after the umount ? :)

@wwwutz
Copy link
Contributor Author

wwwutz commented Mar 3, 2021

I see and recon the trailing smiley. calming down already.

@donald
Copy link
Contributor

donald commented Mar 3, 2021

Ah, okay, perhaps the manual umount races with the mount. I'll test that.

Aynway, go ahead with the /. LGTM.

@donald
Copy link
Contributor

donald commented Mar 13, 2024

Okay, I as confused. On one hand there is no race, on the other hand, stat /pkg/WHATEVER never triggers an automount. umount /pkg/PKG ; tools/build.sh should fail reliably. This only works in the initial run, because the code above touches /pkg/PKG if /package/pkg/PKG doesn't yet exist.

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants