Skip to content

gcc: Update to 12.2.0 #227

Merged
merged 1 commit into from
Mar 15, 2023
Merged

gcc: Update to 12.2.0 #227

merged 1 commit into from
Mar 15, 2023

Conversation

niclas
Copy link
Contributor

@niclas niclas commented Mar 13, 2023

as requested by user

@niclas niclas requested review from donald and thomas March 13, 2023 16:35
@donald
Copy link
Contributor

donald commented Mar 14, 2023

NIT: The commit message should be "gcc: Add version 12.2.0" not "gcc: Update to 12.2.0" and the body should be "Add version 12.2.0 as requested by user." not "as requested by user". Even better: "Create build script with cp gcc-11.1.0-0.build.sh gcc-12.2.0-0.build.sh and update version."
NIT: You've silently changed .tar.xz to .tar.gz. Comment would habe been great, because I've needed a long time to spot, why diff displayed the wget and tar xvf lines.

I'll build it into /package/pkg now.

Add version 12.2.0 as requested by user.

Copy commit with small changes because they ship the tar as
gz and not as xz.
@donald donald merged commit f2de541 into master Mar 15, 2023
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants