add chromium version 72 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test I made: |
pmenzel
reviewed
Mar 14, 2019
chromium-72.0.3626.121-0.build.sh
Outdated
| _chromium_conf=( | ||
| 'is_debug=false' | ||
| 'remove_webcore_debug_symbols=true' | ||
| 'use_gnome_keyring=true' |
There was a problem hiding this comment.
I didn't see it. In atom was everything fine.
It fix now
| out/Release/gn gen out/Release --args="${_chromium_conf[*]}" | ||
|
|
||
| #ninja -C out/Release pdf chrome chromedriver chrome_sandbox | ||
| ninja -C out/Release chrome |
There was a problem hiding this comment.
the build for one takes over a hour on a big maschine. on ex it takes over 6 hour.
So the build takes to long with everything and it is not really needed
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new version of chromium
related to mariux64/bee-files#1055