TEMPLATE.sh: Die, if BUILD_TMPDIR can't be removed #57
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't have the permissions to remove BUILD_TMPDIR (which is quite
likely, when we switch from a test build with a personal user to one
via tools/build.sh with the build user), the current code would ignore
the fact, that the directory can't be removed and continue with a
nonempty directory, possible running into permission problems later.
We could just change
chmod ... && rm -r ...
to
( chmod ... ; rm -r ... )
and the shell would terminate when chmod fails due to permissions.
However, the error message of chmod is different than that of rm:
buczek@afk:~$ chmod u+w /root
chmod: changing permissions of ‘/root’: Operation not permitted
buczek@afk:~$ ls /root/
ls: cannot open directory /root/: Permission denied
I think "Permission denied" is a bit clearer than "Operation not
permitted".
Ignore errors form `chmod` and try `rm` in any case, which either
succeeds or aborts the script with an appropriate error message. Remove
-c flag from chmod because we are not really interested if something has
been changed or not.
Donald Buczek (donald)
force-pushed
the
fix-issue52
branch
from
32817f5 to
d6e56aa
Compare
Sign in
to join this conversation on GitHub.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't have the permissions to remove BUILD_TMPDIR (which is quite
likely, when we switch from a test build with a personal user to one
via tools/build.sh with the build user), the current code would ignore
the fact, that the directory can't be removed and continue with a
nonempty directory, possible running into permission problems later.
We could just change
chmod ... && rm -r ...
to
( chmod ... ; rm -r ... )
and the shell would terminate when chmod fails due to permissions.
However, the error message of chmod is different than that of rm:
I think "Permission denied" is a bit clearer than "Operation not
permitted".
Ignore errors form
chmodand tryrmin any case, which eithersucceeds or aborts the script with an appropriate error message.