Make logs more readable #82
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since script delivers terminal output, the logs look ugly in an editor. The sed line in build.sh pulls line endings straight, additionally 'wget --no-verbose' produces less control character clutter in the logs.
Contributor
|
So many changes and second-though fixes and workarounds, just because we we switched to script as a unreliable workaround to a bug in a single specific package. Perhaps we better undo #66 instead of playing whack-a-mole with script-related problems? |
Contributor
Author
|
On Tue, 10 Sep 2019 10:56:29 +0000 Donald Buczek ***@***.***> wrote:
So many changes and second-though fixes and workarounds, just because
we we switched to script as a unreliable workaround to a bug in a
single specific package.
Perhaps we better undo #66 instead of playing whack-a-mole with
script-related problems?
Reverting to the former way is also acceptable, maybe keep the
'script-powered' variant for pathological cases?
(btw. if this pops up in the git 'chat'-area, then I'm getting closer to
resolve my mailer problems :)
|
Contributor
Author
|
Strike !
(sorry, but I'm so surprised that it works...)
|
Contributor
Author
|
I'll expire this one ... |
Sign in
to join this conversation on GitHub.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since script delivers terminal output, the logs look ugly in an
editor. The sed line in build.sh pulls line endings straight,
additionally 'wget --no-verbose' produces less control
character clutter in the logs.