maketlv() makes a copy of v, so free it.

coverity: 1449503
mariux64 · Aug 1, 2017 · 2a75a2b · 2a75a2b
1 parent 7a47ecf
commit 2a75a2b
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/radsecproxy.c b/radsecproxy.c
@@ -1127,9 +1127,8 @@ makevendortlv(uint32_t vendor, struct tlv *attr)
 	tlv2buf(v + 4, attr);
 	v[5] += 2; /* Vendor length increased for type and length fields. */
 	newtlv = maketlv(RAD_Attr_Vendor_Specific, l, v);
-	if (newtlv == NULL)
-	    free(v);
-	else
+        free(v);
+	if (newtlv)
 	    freetlv(attr);
     }
     return newtlv;