Check return value from setsockopt().

coverity: 1449508, 1449522.
mariux64 · Aug 1, 2017 · 633e4b8 · 633e4b8
1 parent 8aef6cf
commit 633e4b8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/radsecproxy.c b/radsecproxy.c
@@ -2014,13 +2014,15 @@ void createlistener(uint8_t type, char *arg) {
             debugerrno(errno, DBG_WARN, "createlistener: socket failed");
             continue;
         }
-	setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on));
+	if (setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)) == -1)
+            debugerrno(errno, DBG_WARN, "createlistener: SO_REUSEADDR");
 
 	disable_DF_bit(s, res);
 
 #ifdef IPV6_V6ONLY
 	if (res->ai_family == AF_INET6)
-	    setsockopt(s, IPPROTO_IPV6, IPV6_V6ONLY, &on, sizeof(on));
+	    if (setsockopt(s, IPPROTO_IPV6, IPV6_V6ONLY, &on, sizeof(on)) == -1)
+                debugerrno(errno, DBG_WARN, "createlistener: IPV6_V6ONLY");
 #endif
 	if (bind(s, res->ai_addr, res->ai_addrlen)) {
 	    debugerrno(errno, DBG_WARN, "createlistener: bind failed");

diff --git a/util.c b/util.c
@@ -150,10 +150,12 @@ int bindtoaddr(struct addrinfo *addrinfo, int family, int reuse, int v6only) {
 	disable_DF_bit(s,res);
 
 	if (reuse)
-	    setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on));
+	    if (setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)) == -1)
+                debugerrno(errno, DBG_WARN, "Failed to set SO_REUSEADDR");
 #ifdef IPV6_V6ONLY
 	if (v6only)
-	    setsockopt(s, IPPROTO_IPV6, IPV6_V6ONLY, &on, sizeof(on));
+	    if (setsockopt(s, IPPROTO_IPV6, IPV6_V6ONLY, &on, sizeof(on)) == -1)
+                debugerrno(errno, DBG_WARN, "Failed to set IPV6_V6ONLY");
 #endif
 	if (!bind(s, res->ai_addr, res->ai_addrlen))
 	    return s;