Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Look at servers->dynamiclookuparg for deciding if a server is dynamic.
The dynamiclookupcommand member of the _config_ of the server is being
set to NULL when it's copied in confserver_cb(), resulting in dynamic
discovery being done for realms that already have a server.

Patch from Fabian Mauchle.

Addresses RADSECPROXY-69.
  • Loading branch information
Linus Nordberg committed Nov 1, 2016
1 parent 5ccca99 commit 98d7bbe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions develdoc.txt
Expand Up @@ -337,8 +337,8 @@ traverses the list of realms and for each realm:

- same thing for realm->accsrvconfs as for srvconfs

- if none of the realm->srvconfs nor the realm->accsrvonfs has a
dynamiclookupcommand:
- if none of realm->srvconfs->servers and realm->accsrvonfs->servers
have dynamiclookuparg set:

- for each srv in realm->srvconfs: free srv and decrease ref on realm

Expand Down
2 changes: 1 addition & 1 deletion radsecproxy.c
Expand Up @@ -706,7 +706,7 @@ int hasdynamicserver(struct list *srvconfs) {
struct list_node *entry;

for (entry = list_first(srvconfs); entry; entry = list_next(entry))
if (((struct clsrvconf *)entry->data)->dynamiclookupcommand)
if (((struct clsrvconf *)entry->data)->servers->dynamiclookuparg)
return 1;
return 0;
}
Expand Down

0 comments on commit 98d7bbe

Please sign in to comment.