fix coverity issues

mariux64 · Jul 31, 2020 · da884aa · da884aa
1 parent b00b958
commit da884aa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/radmsg.c b/radmsg.c
@@ -296,7 +296,7 @@ struct radmsg *buf2radmsg(uint8_t *buf, uint8_t *secret, int secret_len, uint8_t
     while (p - buf + 2 <= len) {
 	t = *p++;
         l = *p++;
-	if (l < 2) {
+	if (l < 2 || l > 255) {
 	    debug(DBG_WARN, "buf2radmsg: invalid attribute length %d", l);
 	    radmsg_free(msg);
 	    return NULL;

diff --git a/radsecproxy.c b/radsecproxy.c
@@ -3046,7 +3046,8 @@ int radsecproxy_main(int argc, char **argv) {
     sigaddset(&sigset, SIGHUP);
     sigaddset(&sigset, SIGPIPE);
     pthread_sigmask(SIG_BLOCK, &sigset, NULL);
-    pthread_create(&sigth, &pthread_attr, sighandler, NULL);
+    if (pthread_create(&sigth, &pthread_attr, sighandler, NULL))
+        debugx(1, DBG_ERR, "pthread_create failed: sighandler");
 
     for (entry = list_first(srvconfs); entry; entry = list_next(entry)) {
 	srvconf = (struct clsrvconf *)entry->data;