Don't free memory which others are still using.

In the error case in confserver_cb() where compileserverconfig() we used to go to errexit and have resonf, passed as an argument through ARG, freed. Other parts are still using that conf.
mariux64 · Apr 9, 2012 · ed6f9b4 · ed6f9b4
1 parent f41042e
commit ed6f9b4
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/radsecproxy.c b/radsecproxy.c
@@ -2944,7 +2944,8 @@ int confserver_cb(struct gconffile **cf, void *arg, char *block, char *opt, char
 
     if (resconf || !conf->dynamiclookupcommand) {
 	if (!compileserverconfig(conf, block))
-	    goto errexit;
+            return 0; /* Don't goto errexit and free resconf -- it's
+                       * not ours to free.  */
     }
 
     if (!conf->secret) {