Fix display of last day of all-day events in the web calendar #127
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the events model, an event with an end_date but without an end_time is meant to include the last day. Fullcalendar.io, which is used for the web calendar, however, always regards the end datetime as exclusive. Add a day in the case that we have no end_time, so that the web calender includes the last day in the display.
Commit fe8b55e ("publications: Apply flake8 hint fixes") changed some line numbers. Update translations with ./manage.py makemessages -l de --ignore bla/lib/python3.7/site-packages/xlwt
We don't need to use "\n" joiners for the output of the ics.Calendar iterator, because the lines already contain "\r\n" termination. If fact, ics.Calendar.__str__() returns the calendar as an ics formated string, so just return the icx calendar itself. Newer versions of ics have better serialisation, but we don't want to complicate things by library updates now.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In #126 it was identified, that full-day events can be added by just leaving the time fields empty. However, the web calendar wrongly didn't show the last day of full-day events. This is fixed by this PR.
Also included are a few minor cosmetic code changes.
Closes #126