-
Notifications
You must be signed in to change notification settings - Fork 0
Cleanup personal #130
Cleanup personal #130
Commits on Feb 7, 2025
-
Configuration menu - View commit details
-
Copy full SHA for e7cfdaa - Browse repository at this point
Copy the full SHA e7cfdaaView commit details
Commits on Feb 8, 2025
-
personal: Remove Group.members method
In 50dd4a6 ("contactlist: Add selector for Position and Special Function") we remove the only user of this method. Remove dead code.
Configuration menu - View commit details
-
Copy full SHA for f1c9406 - Browse repository at this point
Copy the full SHA f1c9406View commit details -
personal: Fix Contact admin table head
Fix table header for groups Fixes ef3b68f ("Multiple positions per contact")
Configuration menu - View commit details
-
Copy full SHA for 5c01a7f - Browse repository at this point
Copy the full SHA 5c01a7fView commit details -
Create migrations with ./manage.py makemigrations Note, that the new migration doesn't actually change the database scheme: buczek@theinternet:~/git/mpicms (progress)$ ./manage.py sqlmigrate personal 0028 DEBUG 2025-02-08 20:08:42,206 asyncio Using selector: EpollSelector BEGIN; -- -- Change Meta options on group -- -- -- Change Meta options on position -- -- -- Change Meta options on specialfunction -- -- -- Change Meta options on status -- COMMIT;
Configuration menu - View commit details
-
Copy full SHA for 578096e - Browse repository at this point
Copy the full SHA 578096eView commit details
Commits on Feb 9, 2025
-
personal: Change positions to ManyToManyField
We want to split responsibilities for defining positions and assigning contacts to position. Therefore we no longer want the positions inline panel in the contact model admin. Make positions into a simple ManyToMany field. Add sql code to autogenerated migration to transfer data from the old through table "personal_contactpositions" to the new one ("personal_contact_positions"). Adapt queries.
Configuration menu - View commit details
-
Copy full SHA for f43cb59 - Browse repository at this point
Copy the full SHA f43cb59View commit details -
personal: Move Group class definition before Contact
We want to reference Group from Contact in the following commit, so move the class in the source file.
Configuration menu - View commit details
-
Copy full SHA for 108adbb - Browse repository at this point
Copy the full SHA 108adbbView commit details -
personal: Change groups to ManyToManyField
We want to split responsibilities for defining groups and assigning groups to position. Therefore we no longer want thegroupspositions inline panel in the contact model admin. Make groups into a simple ManyToMany field. Add sql code to autogenerated migration to transfer data from the old through table "personal_contactgroups" to the new one ("personal_contact_groups"). Adapt queries.
Configuration menu - View commit details
-
Copy full SHA for 14a1c79 - Browse repository at this point
Copy the full SHA 14a1c79View commit details -
personal: Downgrade from ClusterableModel to Model
We no longer need modelcluster for Groups and Contact, as they are edited seperately. Downgrade base class from modelcluster.models.ClusterableModel to django.db.models.Model
Configuration menu - View commit details
-
Copy full SHA for 4eaae09 - Browse repository at this point
Copy the full SHA 4eaae09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fbd052 - Browse repository at this point
Copy the full SHA 2fbd052View commit details -
personal.views: Remove unnecessary semicolon
Fixes 50dd4a6 ("contactlist: Add selector for Position and Special Function")
Configuration menu - View commit details
-
Copy full SHA for 6a957c5 - Browse repository at this point
Copy the full SHA 6a957c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac2eca9 - Browse repository at this point
Copy the full SHA ac2eca9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 768a10b - Browse repository at this point
Copy the full SHA 768a10bView commit details -
Configuration menu - View commit details
-
Copy full SHA for de599d8 - Browse repository at this point
Copy the full SHA de599d8View commit details -
personal: Rearrange Contact Model Admin
Use FieldsPanels inside a single MutiFieldPanel, because this is a bit compacter. Rearrange order. Intentionally skip "status" for now as the usage is not yet clear and no choices are defined.
Configuration menu - View commit details
-
Copy full SHA for 3142661 - Browse repository at this point
Copy the full SHA 3142661View commit details -
personal: Remove @register_snppet decorator From Position, Group
Only Contact is used as snippet, but not Positon or Group, so remove the @register_snippet decorator.
Configuration menu - View commit details
-
Copy full SHA for 0a502c0 - Browse repository at this point
Copy the full SHA 0a502c0View commit details -
personal: Add Contact string represeantation
Change default string representation from "Dr. Henry Jeckyl" to "Jekyll, Henry". Add property method "name" to return the same representation. Add property name_and_title to return name with title(s) included ("Jekyll, Dr. Henry, PhD MD")
Configuration menu - View commit details
-
Copy full SHA for 148f103 - Browse repository at this point
Copy the full SHA 148f103View commit details -
contactlist: Use name_and_title
Save vertical space by combining names and titles into one column.
Configuration menu - View commit details
-
Copy full SHA for 9b17dc6 - Browse repository at this point
Copy the full SHA 9b17dc6View commit details -
personal: Remove columns from Contact list view
Remove title column from Contact admin list view and rearrange the other columns.
Configuration menu - View commit details
-
Copy full SHA for 865d18c - Browse repository at this point
Copy the full SHA 865d18cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80e672a - Browse repository at this point
Copy the full SHA 80e672aView commit details