Fix name search #131
Merged
Fix name search #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 9b17dc6 ("contactlist: Use name_and_title") the columns were updated, but the searchFunction caller was not so some searches failed. Fix.
"Nachname" ist not correct in all contexts. For example, "name" in the contact list is the full name. Fix to "Name". This is a quickfix which should be reviewed and possibly converted into a gettext context.
donald
force-pushed
the
fix-name-search
branch
from
4d75255
to
93156f6
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9b17dc6 ("contactlist: Use name_and_title") the columns were updated, but the searchFunction caller was not so some searches failed. Fix.