ics: Generate stable UIDs #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derive each event's UID from its page id instead of letting the ics library generate a random one on every download. Random UIDs break calendar sync clients such as vdirsyncer.
The ics library keeps events in a set, so the feed came out in random order. Order by start date and time, newest first, with the page id as tie-breaker, and keep that order through serialization.
Sign in
to join this conversation on GitHub.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the event UIDs are not stable as it is required by RFC 5545. This PR fixes that. Also create the events in a stable order (newest first) to aid in debugging, Some calendars might profit if the relevant current events can be presented to the user right away while the older and mostly historical events are updated later.