events: Fill ics calendar with TZ-aware datetimes #26
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We filled the ics calendar used to produce the ics output with naive datetime specifications without a tiemzone. The ics calendar assument UTC and so the times of the exprted ICS calender were off. The database doesn't containt datetimes, but seperate dates and times which also don't have timezone information. The times are assumend to be the timezone of the server (TIME_ZONE setting in config/settings/base.py). Use astimezone() from pytz library to add time zone information to datetime values handed to the ICS calendar. Acked-By: schrader@molgen.mpg.de
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We filled the ics calendar used to produce the ics output with naive
datetime specifications without a tiemzone. The ics calendar assument
UTC and so the times of the exprted ICS calender were off.
The database doesn't containt datetimes, but seperate dates and times
which also don't have timezone information. The times are assumend to be
the timezone of the server (TIME_ZONE setting in
config/settings/base.py).
Use astimezone() from pytz library to add time zone information to
datetime values handed to the ICS calendar.
Acked-By: schrader@molgen.mpg.de
Fixes #23