More markdown settings #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that for random text the MIME lexer wins:
In [4]: import pygments.lexer
In [5]: pygments.lexers.guess_lexer("Hallo")
Out[5]: <pygments.lexers.MIMELexer>
which usually generates errors for random text:
In [11]: from markdown.extensions.codehilite import CodeHilite
In [12]: CodeHilite(src = 'Hallo').hilite()
Out[12]: '<div class="codehilite"><pre><span></span><span class="err">Hallo</span>\n</pre></div>\n'
which just look ugly (red border on each line).
So switch off language guessing. In that case, code blocks without a
explicit language are left as is:
In [13]: CodeHilite(src = 'Hallo',guess_lang=False).hilite()
Out[13]: '<div class="codehilite"><pre><span></span>Hallo\n</pre></div>\n'
In Markdown, the language should be set explicitly, for language
specific highlighting.
:::python
print("Hallo")
The bulma style sets margin-bottom to 1em for several block-level elements (eg <p>). However the codehilite <div>s, generated by the codehilite Markdown extension don't have that. So we have 1em vertical space before a code block but not after, which just looks wrong. Add vertical space after codehilite <div>s.
Add Admonition extension which allows to add class attributes and a
title to a block. So
!!!alert "Red Alert"
Warp core breach
becomes
<div class="admonition alert">
<p class="admonition-title">Red Alert</p>
<p>Warp core breach</p>
</div>
Add inline style to wagtailadmin/pages/edit.html to force the markdown textarea to monospaced font.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.