Remove remote access to google hosted fonts #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fonts used by this system are already hosted locally. There are, for
example, the following @font-family rules for Merriweather with default
font attributes:
From mpicms/static/css/fonts.css:
From mpicms/templates/fonts.html
}
According to the rules in Css Fonts Module Level3 4.6 "Using character
ranges to define composite fonts", these rules should combine into a
composite font. For code points available in both rules (and font files), the
last rule should take precedence.
However, experiments show, that firefox might download the font files
from the first rule, even though all used code points are in fact available
from the second rule.
Although it remains unclear, why exactly the rules with the remote urls
are used, this is something we don't want for privacy reasons.
Remove fonts.css and its references. All fonts used by the cms are
assumed to be provided by the rules in the fonts.html template.
A quick visual comparison didn't show any visible difference, whether
fonts.css is removed or not.
Fixes #58