Fix languagepicker #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
donald
commented
Sep 16, 2020
donald
commented
- all languages should again be enabled by default on the edit pages
- Some very minor changes
Fix all code style issues signaled by
flake8 mpicms/
Remove call to register_admin_urls, because it seems redundant. mpicms.users.urls is also included via config.urlpatterns.
The app namespace wagtailusers_users is already taken by the unmodified
wagtail admin app. So we get a warning
?: (urls.W005) URL namespace 'wagtailusers_users' isn't unique. You may not be able to reverse all URLs in this namespace
on startup. Our modified users app doesn't need to use the same app
namespace. Even if a template uses wagtailusrs_users:something, it would
resolve to a url which we mapped.
Change from django.defaults.page_not_found view with complicated semantics to raise django.http.Http404.
It doesn't seem necessary to register wagtail.users.views.index, because it is already there. So don't do it.
* lint: users; Remove index view users: Simplify masking of disabled functions users: Change app namespace users: Remove wagtail_hooks Apply code style fixes
Use branch add-toggle-configure from our clone of wagtail-modeltranslation until its PR [1] is decided. [1] https://github.com/infoportugal/wagtail-modeltranslation/pull/301
Update python requirements with
(cd requirements; make)
The virtual environment can be update to the specified versions with
pip-sync requirements/dev.txt
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.