Skip to content

Commit

Permalink
Merge branch 'jc/maint-fix-unpack-zlib-check' into maint
Browse files Browse the repository at this point in the history
* jc/maint-fix-unpack-zlib-check:
  Fix incorrect error check while reading deflated pack data
  • Loading branch information
Junio C Hamano committed Oct 26, 2009
2 parents 071b489 + 39eea7b commit 47a876a
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions sha1_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -1357,8 +1357,6 @@ unsigned long get_size_from_delta(struct packed_git *p,
in = use_pack(p, w_curs, curpos, &stream.avail_in);
stream.next_in = in;
st = git_inflate(&stream, Z_FINISH);
if (st == Z_BUF_ERROR && (stream.avail_in || !stream.avail_out))
break;
curpos += stream.next_in - in;
} while ((st == Z_OK || st == Z_BUF_ERROR) &&
stream.total_out < sizeof(delta_head));
Expand Down Expand Up @@ -1589,15 +1587,15 @@ static void *unpack_compressed_entry(struct packed_git *p,
buffer[size] = 0;
memset(&stream, 0, sizeof(stream));
stream.next_out = buffer;
stream.avail_out = size;
stream.avail_out = size + 1;

git_inflate_init(&stream);
do {
in = use_pack(p, w_curs, curpos, &stream.avail_in);
stream.next_in = in;
st = git_inflate(&stream, Z_FINISH);
if (st == Z_BUF_ERROR && (stream.avail_in || !stream.avail_out))
break;
if (!stream.avail_out)
break; /* the payload is larger than it should be */
curpos += stream.next_in - in;
} while (st == Z_OK || st == Z_BUF_ERROR);
git_inflate_end(&stream);
Expand Down

0 comments on commit 47a876a

Please sign in to comment.