Skip to content

Commit

Permalink
cvsserver: remove unused functions _headrev and gethistory
Browse files Browse the repository at this point in the history
Remove:
   - _headrev() - It uses similar functionality from getmeta() and gethead().
   - gethistory() - It uses similar functions gethistorydense() and getlog().

Signed-off-by: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Matthew Ogilvie authored and Junio C Hamano committed Oct 16, 2012
1 parent d8574ff commit a86c098
Showing 1 changed file with 4 additions and 32 deletions.
36 changes: 4 additions & 32 deletions git-cvsserver.perl
Original file line number Diff line number Diff line change
Expand Up @@ -3440,19 +3440,6 @@ sub insert_head
$insert_head->execute($name, $revision, $filehash, $commithash, $modified, $author, $mode);
}

sub _headrev
{
my $self = shift;
my $filename = shift;
my $tablename = $self->tablename("head");

my $db_query = $self->{dbh}->prepare_cached("SELECT filehash, revision, mode FROM $tablename WHERE name=?",{},1);
$db_query->execute($filename);
my ( $hash, $revision, $mode ) = $db_query->fetchrow_array;

return ( $hash, $revision, $mode );
}

sub _get_prop
{
my $self = shift;
Expand Down Expand Up @@ -3512,6 +3499,8 @@ sub gethead

=head2 getlog
See also gethistorydense().
=cut

sub getlog
Expand Down Expand Up @@ -3597,25 +3586,6 @@ sub commitmessage
return $message;
}

=head2 gethistory
This function takes a filename (with path) argument and returns an arrayofarrays
containing revision,filehash,commithash ordered by revision descending
=cut
sub gethistory
{
my $self = shift;
my $filename = shift;
my $tablename = $self->tablename("revision");

my $db_query;
$db_query = $self->{dbh}->prepare_cached("SELECT revision, filehash, commithash FROM $tablename WHERE name=? ORDER BY revision DESC",{},1);
$db_query->execute($filename);

return $db_query->fetchall_arrayref;
}

=head2 gethistorydense
This function takes a filename (with path) argument and returns an arrayofarrays
Expand All @@ -3625,6 +3595,8 @@ =head2 gethistorydense
The 'dense' part is a reference to a '--dense' option available for git-rev-list
and other git tools that depend on it.
See also getlog().
=cut
sub gethistorydense
{
Expand Down

0 comments on commit a86c098

Please sign in to comment.