Skip to content

Commit

Permalink
[BZ #157]
Browse files Browse the repository at this point in the history
	* include/libc-symbols.h (stub_warning): Emit a marker section called
	.gnu.glibc-stub.NAME.
	* Makerules ($(objpfx)stubs): Depend on object files, not dep files.
	Use objdump to collect those marker section names.
	($(common-objpfx)shlib.lds): Discard .gnu.glibc-stub.* sections.
  • Loading branch information
Roland McGrath committed Feb 11, 2005
1 parent 5d9e899 commit 561bcb8
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 16 deletions.
7 changes: 7 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
2005-02-10 Roland McGrath <roland@redhat.com>

[BZ #157]
* include/libc-symbols.h (stub_warning): Emit a marker section called
.gnu.glibc-stub.NAME.
* Makerules ($(objpfx)stubs): Depend on object files, not dep files.
Use objdump to collect those marker section names.
($(common-objpfx)shlib.lds): Discard .gnu.glibc-stub.* sections.

* Rules (subdir_objs, subdir_stubs): New phony targets.
* Makefile (+subdir_targets): Add them.

Expand Down
27 changes: 12 additions & 15 deletions Makerules
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ $(common-objpfx)shlib.lds: $(common-objpfx)config.make $(..)Makerules
PROVIDE(__start___libc_freeres_ptrs = .); \
*(__libc_freeres_ptrs) \
PROVIDE(__stop___libc_freeres_ptrs = .);/'\
-e 's/^.*\*(\.jcr).*$$/& \
-e 's@^.*\*(\.jcr).*$$@& \
PROVIDE(__start___libc_subfreeres = .);\
__libc_subfreeres : { *(__libc_subfreeres) }\
PROVIDE(__stop___libc_subfreeres = .);\
Expand All @@ -501,7 +501,8 @@ $(common-objpfx)shlib.lds: $(common-objpfx)config.make $(..)Makerules
PROVIDE(__stop___libc_atexit = .);\
PROVIDE(__start___libc_thread_subfreeres = .);\
__libc_thread_subfreeres : { *(__libc_thread_subfreeres) }\
PROVIDE(__stop___libc_thread_subfreeres = .);/'
PROVIDE(__stop___libc_thread_subfreeres = .);\
/DISCARD/ : { *(.gnu.glibc-stub.*) }@'
mv -f $@T $@
common-generated += shlib.lds

Expand Down Expand Up @@ -1385,19 +1386,15 @@ ifdef objpfx
.PHONY: stubs # The parent Makefile calls this target.
stubs: $(objpfx)stubs
endif
$(objpfx)stubs: $(+depfiles)
ifneq (,$(strip $(+depfiles)))
# Use /dev/null since `...` might expand to empty.
c=`($(patsubst %/,cd % &&,$(objpfx)) \
sed -n -e 's@\$$(common-objpfx)@$(common-objpfx)@g' \
-e 's@\$$(objpfx)@$(objpfx)@g' \
-e '/stub-tag\.h/{; g; s/./&/p; }' \
-e '/:/{x; s/^.*$$//; x; }' \
-e 's/^.*://;s/\\$$//;s/^ *\([^ ][^ ]*\) .*$$/\1/' \
-e '/^[^ ][^ ]*$$/{G;s/^.*\n\(..*\)/\1/;s/\n//;h; }' \
$(patsubst $(objpfx)%,%,$^)) | sort | uniq`; \
sed -n 's/^stub_warning *(\([^)]*\).*$$/#define __stub_\1/p' \
$$c /dev/null > $@T
objs-for-stubs := $(foreach o,$(object-suffixes-for-libc),$(o-objects)) \
$(addprefix $(objpfx),$(extra-objs))
$(objpfx)stubs: $(objs-for-stubs)
ifneq (,$(strip $(objs-for-stubs)))
$(OBJDUMP) -h $^ | \
$(AWK) '/\.gnu\.glibc-stub\./ { \
sub(/\.gnu\.glibc-stub\./, "", $$2); \
stubs[$$2] = 1; } \
END { for (s in stubs) print "#define __stub_" s }' > $@T
mv -f $@T $@
else
> $@
Expand Down
3 changes: 2 additions & 1 deletion include/libc-symbols.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* Support macros for making weak and strong aliases for symbols,
and for using symbol sets and linker warnings with GNU ld.
Copyright (C) 1995-1998,2000-2003,2004 Free Software Foundation, Inc.
Copyright (C) 1995-1998,2000-2003,2004, 2005 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
Expand Down Expand Up @@ -279,6 +279,7 @@

/* A canned warning for sysdeps/stub functions. */
#define stub_warning(name) \
__make_section_unallocated (".gnu.glibc-stub." #name) \
link_warning (name, \
"warning: " #name " is not implemented and will always fail")

Expand Down

0 comments on commit 561bcb8

Please sign in to comment.