Skip to content

Commit

Permalink
x86: use remove_from_maps in cpu_disable
Browse files Browse the repository at this point in the history
it is already used in x86_64. In i386, it only
removes from cpu_online_map

Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Glauber Costa authored and Ingo Molnar committed Apr 17, 2008
1 parent fc25da9 commit 045f9d2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
7 changes: 6 additions & 1 deletion arch/x86/kernel/smpboot_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -1041,6 +1041,11 @@ void __init native_smp_prepare_boot_cpu(void)
}

#ifdef CONFIG_HOTPLUG_CPU
static void __ref remove_cpu_from_maps(int cpu)
{
cpu_clear(cpu, cpu_online_map);
}

int __cpu_disable(void)
{
cpumask_t map = cpu_online_map;
Expand All @@ -1066,7 +1071,7 @@ int __cpu_disable(void)

remove_siblinginfo(cpu);

cpu_clear(cpu, map);
remove_cpu_from_maps(cpu);
fixup_irqs(map);
/* It's now safe to remove this processor from the online map */
cpu_clear(cpu, cpu_online_map);
Expand Down
8 changes: 3 additions & 5 deletions arch/x86/kernel/smpboot_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -838,10 +838,9 @@ void __init native_smp_cpus_done(unsigned int max_cpus)
}

#ifdef CONFIG_HOTPLUG_CPU
static void __ref remove_cpu_from_maps(void)
static void __ref remove_cpu_from_maps(int cpu)
{
int cpu = smp_processor_id();

cpu_clear(cpu, cpu_online_map);
cpu_clear(cpu, cpu_callout_map);
cpu_clear(cpu, cpu_callin_map);
clear_bit(cpu, (unsigned long *)&cpu_initialized); /* was set by cpu_init() */
Expand Down Expand Up @@ -880,8 +879,7 @@ int __cpu_disable(void)
remove_siblinginfo(cpu);

/* It's now safe to remove this processor from the online map */
cpu_clear(cpu, cpu_online_map);
remove_cpu_from_maps();
remove_cpu_from_maps(cpu);
fixup_irqs(cpu_online_map);
return 0;
}
Expand Down

0 comments on commit 045f9d2

Please sign in to comment.