Skip to content

Commit

Permalink
mtd: cmx270_nand.c: use mtd_device_parse_register
Browse files Browse the repository at this point in the history
Replace custom invocations of parse_mtd_partitions and mtd_device_register
with common mtd_device_parse_register call. This would bring: standard
handling of all errors, fallback to default partitions, etc.

Artem: tweaked the patch

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
  • Loading branch information
Dmitry Eremin-Solenikov authored and Artem Bityutskiy committed Sep 11, 2011
1 parent 4d32de8 commit 0b118f0
Showing 1 changed file with 2 additions and 18 deletions.
20 changes: 2 additions & 18 deletions drivers/mtd/nand/cmx270_nand.c
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,6 @@ static int cmx270_device_ready(struct mtd_info *mtd)
static int __init cmx270_init(void)
{
struct nand_chip *this;
const char *part_type;
struct mtd_partition *mtd_parts;
int mtd_parts_nb = 0;
int ret;

if (!(machine_is_armcore() && cpu_is_pxa27x()))
Expand Down Expand Up @@ -220,22 +217,9 @@ static int __init cmx270_init(void)
goto err_scan;
}

mtd_parts_nb = parse_mtd_partitions(cmx270_nand_mtd, NULL,
&mtd_parts, 0);
if (mtd_parts_nb > 0)
part_type = "command line";
else
mtd_parts_nb = 0;

if (!mtd_parts_nb) {
mtd_parts = partition_info;
mtd_parts_nb = NUM_PARTITIONS;
part_type = "static";
}

/* Register the partitions */
pr_notice("Using %s partition definition\n", part_type);
ret = mtd_device_register(cmx270_nand_mtd, mtd_parts, mtd_parts_nb);
ret = mtd_device_parse_register(cmx270_nand_mtd, NULL, 0,
partition_info, NUM_PARTITIONS);
if (ret)
goto err_scan;

Expand Down

0 comments on commit 0b118f0

Please sign in to comment.