Skip to content

Commit

Permalink
squashfs: xattr fix sparse warnings
Browse files Browse the repository at this point in the history
Sparse does not like inline function declared without body,
because it is not part of the standard kernel practice.

The xattr_handler tables can be declared static.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Phillip Lougher <phillip@lougher.demon.co.uk>
  • Loading branch information
Stephen Hemminger authored and Phillip Lougher committed May 17, 2010
1 parent aa5b189 commit 0f87ee0
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions fs/squashfs/xattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
#include "squashfs_fs_i.h"
#include "squashfs.h"

static inline struct xattr_handler *squashfs_xattr_handler(int);
static struct xattr_handler *squashfs_xattr_handler(int);

ssize_t squashfs_listxattr(struct dentry *d, char *buffer,
size_t buffer_size)
Expand Down Expand Up @@ -228,7 +228,7 @@ static int squashfs_user_get(struct dentry *d, const char *name, void *buffer,
buffer, size);
}

struct xattr_handler squashfs_xattr_user_handler = {
static struct xattr_handler squashfs_xattr_user_handler = {
.prefix = XATTR_USER_PREFIX,
.list = squashfs_user_list,
.get = squashfs_user_get
Expand Down Expand Up @@ -258,7 +258,7 @@ static int squashfs_trusted_get(struct dentry *d, const char *name,
buffer, size);
}

struct xattr_handler squashfs_xattr_trusted_handler = {
static struct xattr_handler squashfs_xattr_trusted_handler = {
.prefix = XATTR_TRUSTED_PREFIX,
.list = squashfs_trusted_list,
.get = squashfs_trusted_get
Expand All @@ -285,7 +285,7 @@ static int squashfs_security_get(struct dentry *d, const char *name,
buffer, size);
}

struct xattr_handler squashfs_xattr_security_handler = {
static struct xattr_handler squashfs_xattr_security_handler = {
.prefix = XATTR_SECURITY_PREFIX,
.list = squashfs_security_list,
.get = squashfs_security_get
Expand Down

0 comments on commit 0f87ee0

Please sign in to comment.