Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 145935
b: refs/heads/master
c: e7ed70e
h: refs/heads/master
i:
  145933: 0918c70
  145931: e3d1c06
  145927: 6fd82e7
  145919: fb09de9
v: v3
  • Loading branch information
Joerg Roedel committed Jun 8, 2009
1 parent e1615ab commit 12b65c5
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 22 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: c17e2cf7376a2010b8b114fdeebd4e340a5e9cb2
refs/heads/master: e7ed70eedccc78e79ce6da2155e9caf90aff4003
36 changes: 15 additions & 21 deletions trunk/lib/dma-debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ static inline void dump_entry_trace(struct dma_debug_entry *entry)
{
#ifdef CONFIG_STACKTRACE
if (entry) {
printk(KERN_WARNING "Mapped at:\n");
pr_warning("Mapped at:\n");
print_stack_trace(&entry->stacktrace, 0);
}
#endif
Expand Down Expand Up @@ -377,8 +377,7 @@ static struct dma_debug_entry *dma_entry_alloc(void)
spin_lock_irqsave(&free_entries_lock, flags);

if (list_empty(&free_entries)) {
printk(KERN_ERR "DMA-API: debugging out of memory "
"- disabling\n");
pr_err("DMA-API: debugging out of memory - disabling\n");
global_disable = true;
goto out;
}
Expand Down Expand Up @@ -483,8 +482,7 @@ static int prealloc_memory(u32 num_entries)
num_free_entries = num_entries;
min_free_entries = num_entries;

printk(KERN_INFO "DMA-API: preallocated %d debug entries\n",
num_entries);
pr_info("DMA-API: preallocated %d debug entries\n", num_entries);

return 0;

Expand Down Expand Up @@ -534,7 +532,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
* disabled. Since copy_from_user can fault and may sleep we
* need to copy to temporary buffer first
*/
len = min(count, NAME_MAX_LEN - 1);
len = min(count, (size_t)(NAME_MAX_LEN - 1));
if (copy_from_user(buf, userbuf, len))
return -EFAULT;

Expand All @@ -557,8 +555,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
* switched off.
*/
if (current_driver_name[0])
printk(KERN_INFO "DMA-API: switching off dma-debug "
"driver filter\n");
pr_info("DMA-API: switching off dma-debug driver filter\n");
current_driver_name[0] = 0;
current_driver = NULL;
goto out_unlock;
Expand All @@ -576,8 +573,8 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
current_driver_name[i] = 0;
current_driver = NULL;

printk(KERN_INFO "DMA-API: enable driver filter for driver [%s]\n",
current_driver_name);
pr_info("DMA-API: enable driver filter for driver [%s]\n",
current_driver_name);

out_unlock:
write_unlock_irqrestore(&driver_name_lock, flags);
Expand All @@ -594,7 +591,7 @@ static int dma_debug_fs_init(void)
{
dma_debug_dent = debugfs_create_dir("dma-api", NULL);
if (!dma_debug_dent) {
printk(KERN_ERR "DMA-API: can not create debugfs directory\n");
pr_err("DMA-API: can not create debugfs directory\n");
return -ENOMEM;
}

Expand Down Expand Up @@ -693,7 +690,7 @@ void dma_debug_add_bus(struct bus_type *bus)

nb = kzalloc(sizeof(struct notifier_block), GFP_KERNEL);
if (nb == NULL) {
printk(KERN_ERR "dma_debug_add_bus: out of memory\n");
pr_err("dma_debug_add_bus: out of memory\n");
return;
}

Expand All @@ -718,8 +715,7 @@ void dma_debug_init(u32 num_entries)
}

if (dma_debug_fs_init() != 0) {
printk(KERN_ERR "DMA-API: error creating debugfs entries "
"- disabling\n");
pr_err("DMA-API: error creating debugfs entries - disabling\n");
global_disable = true;

return;
Expand All @@ -729,16 +725,15 @@ void dma_debug_init(u32 num_entries)
num_entries = req_entries;

if (prealloc_memory(num_entries) != 0) {
printk(KERN_ERR "DMA-API: debugging out of memory error "
"- disabled\n");
pr_err("DMA-API: debugging out of memory error - disabled\n");
global_disable = true;

return;
}

nr_total_entries = num_free_entries;

printk(KERN_INFO "DMA-API: debugging enabled by kernel config\n");
pr_info("DMA-API: debugging enabled by kernel config\n");
}

static __init int dma_debug_cmdline(char *str)
Expand All @@ -747,8 +742,7 @@ static __init int dma_debug_cmdline(char *str)
return -EINVAL;

if (strncmp(str, "off", 3) == 0) {
printk(KERN_INFO "DMA-API: debugging disabled on kernel "
"command line\n");
pr_info("DMA-API: debugging disabled on kernel command line\n");
global_disable = true;
}

Expand Down Expand Up @@ -1239,8 +1233,8 @@ static int __init dma_debug_driver_setup(char *str)
}

if (current_driver_name[0])
printk(KERN_INFO "DMA-API: enable driver filter for "
"driver [%s]\n", current_driver_name);
pr_info("DMA-API: enable driver filter for driver [%s]\n",
current_driver_name);


return 1;
Expand Down

0 comments on commit 12b65c5

Please sign in to comment.