Skip to content

Commit

Permalink
[NET_SCHED]: sch_ingress: avoid a few #ifdefs
Browse files Browse the repository at this point in the history
Move the repeating "ifndef CONFIG_NET_CLS_ACT/ifdef CONFIG_NETFILTER"
ifdefs into a single condition.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Patrick McHardy authored and David S. Miller committed Jan 28, 2008
1 parent 645a1e3 commit 1389356
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions net/sched/sch_ingress.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,9 @@


/* Thanks to Doron Oz for this hack */
#ifndef CONFIG_NET_CLS_ACT
#ifdef CONFIG_NETFILTER
#if !defined(CONFIG_NET_CLS_ACT) && defined(CONFIG_NETFILTER)
static int nf_registered;
#endif
#endif

struct ingress_qdisc_data {
struct tcf_proto *filter_list;
Expand Down Expand Up @@ -118,8 +116,7 @@ static int ingress_enqueue(struct sk_buff *skb, struct Qdisc *sch)
return result;
}

#ifndef CONFIG_NET_CLS_ACT
#ifdef CONFIG_NETFILTER
#if !defined(CONFIG_NET_CLS_ACT) && defined(CONFIG_NETFILTER)
static unsigned int ing_hook(unsigned int hook, struct sk_buff *skb,
const struct net_device *indev,
const struct net_device *outdev,
Expand Down Expand Up @@ -158,12 +155,10 @@ static struct nf_hook_ops ing_ops[] __read_mostly = {
},
};
#endif
#endif

static int ingress_init(struct Qdisc *sch, struct rtattr *opt)
{
#ifndef CONFIG_NET_CLS_ACT
#ifdef CONFIG_NETFILTER
#if !defined(CONFIG_NET_CLS_ACT) && defined(CONFIG_NETFILTER)
printk("Ingress scheduler: Classifier actions prefered over netfilter\n");

if (!nf_registered) {
Expand All @@ -173,7 +168,6 @@ static int ingress_init(struct Qdisc *sch, struct rtattr *opt)
}
nf_registered++;
}
#endif
#endif
return 0;
}
Expand Down Expand Up @@ -240,12 +234,10 @@ static int __init ingress_module_init(void)
static void __exit ingress_module_exit(void)
{
unregister_qdisc(&ingress_qdisc_ops);
#ifndef CONFIG_NET_CLS_ACT
#ifdef CONFIG_NETFILTER
#if !defined(CONFIG_NET_CLS_ACT) && defined(CONFIG_NETFILTER)
if (nf_registered)
nf_unregister_hooks(ing_ops, ARRAY_SIZE(ing_ops));
#endif
#endif
}

module_init(ingress_module_init)
Expand Down

0 comments on commit 1389356

Please sign in to comment.