Skip to content

Commit

Permalink
ACPI: call acpi_system_init() explicitly rather than as initcall
Browse files Browse the repository at this point in the history
This patch makes acpi_init() call acpi_system_init() directly.
Previously, both were subsys_initcalls.  acpi_system_init()
must happen after acpi_init(), and it's better to call it
explicitly rather than rely on link ordering.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Bjorn Helgaas authored and Len Brown committed Mar 27, 2009
1 parent 4451537 commit 141a0af
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
1 change: 1 addition & 0 deletions drivers/acpi/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -882,6 +882,7 @@ static int __init acpi_init(void)
acpi_scan_init();
acpi_ec_init();
acpi_power_init();
acpi_system_init();
return result;
}

Expand Down
1 change: 1 addition & 0 deletions drivers/acpi/internal.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* For use by Linux/ACPI infrastructure, not drivers */

int acpi_scan_init(void);
int acpi_system_init(void);

/* --------------------------------------------------------------------------
Power Resource
Expand Down
9 changes: 2 additions & 7 deletions drivers/acpi/system.c
Original file line number Diff line number Diff line change
Expand Up @@ -571,12 +571,9 @@ static int acpi_system_procfs_init(void)
}
#endif

static int __init acpi_system_init(void)
int __init acpi_system_init(void)
{
int result = 0;

if (acpi_disabled)
return 0;
int result;

result = acpi_system_procfs_init();
if (result)
Expand All @@ -586,5 +583,3 @@ static int __init acpi_system_init(void)

return result;
}

subsys_initcall(acpi_system_init);

0 comments on commit 141a0af

Please sign in to comment.