Skip to content

Commit

Permalink
[ARM] mmp2: fix incorrect calling of chip->mask_ack() for 2nd level c…
Browse files Browse the repository at this point in the history
…ascaded IRQs

The irq_chip is not yet registered, so no default irq_chip.mask_ack(),
which we have to handle it correctly manually here.

Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
  • Loading branch information
Eric Miao committed Mar 1, 2010
1 parent df0c382 commit 2029e56
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion arch/arm/mach-mmp/irq-mmp2.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ static void init_mux_irq(struct irq_chip *chip, int start, int num)
int irq;

for (irq = start; num > 0; irq++, num--) {
chip->mask_ack(irq);
/* mask and clear the IRQ */
chip->mask(irq);
if (chip->ack)
chip->ack(irq);

set_irq_chip(irq, chip);
set_irq_flags(irq, IRQF_VALID);
set_irq_handler(irq, handle_level_irq);
Expand Down

0 comments on commit 2029e56

Please sign in to comment.