Skip to content

Commit

Permalink
net: sky2: remove unnecessary pci_set_drvdata()
Browse files Browse the repository at this point in the history
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jingoo Han authored and David S. Miller committed Oct 21, 2013
1 parent 68e35d8 commit 21d35d2
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/net/ethernet/marvell/sky2.c
Original file line number Diff line number Diff line change
Expand Up @@ -5081,7 +5081,6 @@ static int sky2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
err_out_disable:
pci_disable_device(pdev);
err_out:
pci_set_drvdata(pdev, NULL);
return err;
}

Expand Down Expand Up @@ -5124,8 +5123,6 @@ static void sky2_remove(struct pci_dev *pdev)

iounmap(hw->regs);
kfree(hw);

pci_set_drvdata(pdev, NULL);
}

static int sky2_suspend(struct device *dev)
Expand Down

0 comments on commit 21d35d2

Please sign in to comment.