Skip to content

Commit

Permalink
wpan: use stack buffer instead of heap
Browse files Browse the repository at this point in the history
head buffer is only temporary available in mac802154_header_create.
So it's not necessary to put it on the heap.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexander Aring authored and David S. Miller committed Feb 6, 2013
1 parent fc4e98d commit 25060d8
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions net/mac802154/wpan.c
Original file line number Diff line number Diff line change
Expand Up @@ -137,16 +137,12 @@ static int mac802154_header_create(struct sk_buff *skb,
struct ieee802154_addr dev_addr;
struct mac802154_sub_if_data *priv = netdev_priv(dev);
int pos = 2;
u8 *head;
u8 head[MAC802154_FRAME_HARD_HEADER_LEN];
u16 fc;

if (!daddr)
return -EINVAL;

head = kzalloc(MAC802154_FRAME_HARD_HEADER_LEN, GFP_KERNEL);
if (head == NULL)
return -ENOMEM;

head[pos++] = mac_cb(skb)->seq; /* DSN/BSN */
fc = mac_cb_type(skb);

Expand Down Expand Up @@ -210,7 +206,6 @@ static int mac802154_header_create(struct sk_buff *skb,
head[1] = fc >> 8;

memcpy(skb_push(skb, pos), head, pos);
kfree(head);

return pos;
}
Expand Down

0 comments on commit 25060d8

Please sign in to comment.