Skip to content

Commit

Permalink
drivers/platform/x86: Use kmemdup
Browse files Browse the repository at this point in the history
Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
  • Loading branch information
Julia Lawall authored and Matthew Garrett committed May 20, 2010
1 parent 6c75dd0 commit 2c6719a
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/platform/x86/wmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -756,12 +756,10 @@ static __init acpi_status parse_wdg(acpi_handle handle)

total = obj->buffer.length / sizeof(struct guid_block);

gblock = kzalloc(obj->buffer.length, GFP_KERNEL);
gblock = kmemdup(obj->buffer.pointer, obj->buffer.length, GFP_KERNEL);
if (!gblock)
return AE_NO_MEMORY;

memcpy(gblock, obj->buffer.pointer, obj->buffer.length);

for (i = 0; i < total; i++) {
/*
Some WMI devices, like those for nVidia hooks, have a
Expand Down

0 comments on commit 2c6719a

Please sign in to comment.