Skip to content

Commit

Permalink
V4L/DVB (6580): Set slave's master before master's attach call.
Browse files Browse the repository at this point in the history
V4L: Int if: Set slave's master before attach, remove master argument

The master also now gets its own pointer from slave's structure.

Signed-off-by: Sakari Ailus <sakari.ailus@nokia.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Sakari Ailus authored and Mauro Carvalho Chehab committed Jan 25, 2008
1 parent 53133af commit 2c94a67
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
6 changes: 3 additions & 3 deletions drivers/media/video/v4l2-int-device.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ static void v4l2_int_device_try_attach_all(void)
if (!try_module_get(m->module))
continue;

if (m->u.master->attach(m, s)) {
s->u.slave->master = m;
if (m->u.master->attach(s)) {
s->u.slave->master = NULL;
module_put(m->module);
continue;
}

s->u.slave->master = m;
}
}
}
Expand Down
5 changes: 2 additions & 3 deletions include/media/v4l2-int-device.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,8 @@ enum v4l2_int_type {
struct v4l2_int_device;

struct v4l2_int_master {
int (*attach)(struct v4l2_int_device *master,
struct v4l2_int_device *slave);
void (*detach)(struct v4l2_int_device *master);
int (*attach)(struct v4l2_int_device *slave);
void (*detach)(struct v4l2_int_device *slave);
};

typedef int (v4l2_int_ioctl_func)(struct v4l2_int_device *);
Expand Down

0 comments on commit 2c94a67

Please sign in to comment.