---

yaml --- r: 93298 b: refs/heads/master c: e298449 h: refs/heads/master v: v3
git-mirror · Apr 25, 2008 · 362c5ef · 362c5ef
1 parent 3387a12
commit 362c5ef
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 9b0f2582d57d4c9081307c86e11afc9169de7d3e
+refs/heads/master: e298449401463dd18f24a87c48f9b0ec62bad936
diff --git a/trunk/drivers/usb/serial/mos7840.c b/trunk/drivers/usb/serial/mos7840.c
@@ -1722,6 +1722,7 @@ static int mos7840_tiocmset(struct usb_serial_port *port, struct file *file,
 	if (mos7840_port == NULL)
 		return -ENODEV;
 
+	/* FIXME: What locks the port registers ? */
 	mcr = mos7840_port->shadowMCR;
 	if (clear & TIOCM_RTS)
 		mcr &= ~MCR_RTS;

diff --git a/trunk/drivers/usb/serial/option.c b/trunk/drivers/usb/serial/option.c
@@ -458,6 +458,7 @@ static int option_tiocmset(struct usb_serial_port *port, struct file *file,
 
 	portdata = usb_get_serial_port_data(port);
 
+	/* FIXME: what locks portdata fields ? */
 	if (set & TIOCM_RTS)
 		portdata->rts_state = 1;
 	if (set & TIOCM_DTR)