Skip to content

Commit

Permalink
[media] tuners/xc4000: Replace memcpy with struct assignment
Browse files Browse the repository at this point in the history
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Ezequiel Garcia authored and Mauro Carvalho Chehab committed Dec 27, 2012
1 parent f01e0ff commit 3662873
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/tuners/xc4000.c
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ static int check_firmware(struct dvb_frontend *fe, unsigned int type,
goto fail;
}

memcpy(&priv->cur_fw, &new_fw, sizeof(priv->cur_fw));
priv->cur_fw = new_fw;

/*
* By setting BASE in cur_fw.type only after successfully loading all
Expand Down

0 comments on commit 3662873

Please sign in to comment.