Skip to content

Commit

Permalink
[PATCH] uml: fix bogus HOST_ELF_CLASS symbol name
Browse files Browse the repository at this point in the history
Even if with a bit of misunderstanding, Al fixed this in commit
9560826.

Well, the symbol was intended to come from userspace (it exists there on normal
host), but since some hosts may miss that, using the kernel one is just as fine.
However, rename it to be named consistently with the rest.

Actually, he missed converting ELFCLASS32 to coming from kernel headers. For
consistence, add ELFCLASS64 too.

Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Paolo 'Blaisorblade' Giarrusso authored and Linus Torvalds committed Sep 21, 2005
1 parent fd74810 commit 41c79dc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 3 additions & 1 deletion arch/um/include/common-offsets.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,6 @@ DEFINE_STR(UM_KERN_WARNING, KERN_WARNING);
DEFINE_STR(UM_KERN_NOTICE, KERN_NOTICE);
DEFINE_STR(UM_KERN_INFO, KERN_INFO);
DEFINE_STR(UM_KERN_DEBUG, KERN_DEBUG);
DEFINE(HOST_ELF_CLASS, ELF_CLASS);
DEFINE(UM_ELF_CLASS, ELF_CLASS);
DEFINE(UM_ELFCLASS32, ELFCLASS32);
DEFINE(UM_ELFCLASS64, ELFCLASS64);
3 changes: 2 additions & 1 deletion arch/um/os-Linux/elf_aux.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
#include "mem_user.h"
#include <kernel-offsets.h>

#if HOST_ELF_CLASS == ELFCLASS32
/* Use the one from the kernel - the host may miss it, if having old headers. */
#if UM_ELF_CLASS == UM_ELFCLASS32
typedef Elf32_auxv_t elf_auxv_t;
#else
typedef Elf64_auxv_t elf_auxv_t;
Expand Down

0 comments on commit 41c79dc

Please sign in to comment.