Skip to content

Commit

Permalink
leds: lp3944: Fix return value
Browse files Browse the repository at this point in the history
Return the value obtained from i2c_smbus_read_byte_data() instead of
-EINVAL. Silences the following smatch warning:
drivers/leds/leds-lp3944.c:89 lp3944_reg_read() info:
why not propagate 'tmp' from i2c_smbus_read_byte_data() instead of -22?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
  • Loading branch information
Sachin Kamat authored and Bryan Wu committed Nov 26, 2012
1 parent 5ebab74 commit 4401e48
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/leds/leds-lp3944.c
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ static int lp3944_reg_read(struct i2c_client *client, u8 reg, u8 *value)

tmp = i2c_smbus_read_byte_data(client, reg);
if (tmp < 0)
return -EINVAL;
return tmp;

*value = tmp;

Expand Down

0 comments on commit 4401e48

Please sign in to comment.