Skip to content

Commit

Permalink
Merge branch 'sh_eth'
Browse files Browse the repository at this point in the history
Sergei Shtylyov says:

====================
Add PHY IRQ support to the 'sh_eth' driver

   This patchset adds support for passing PHY's IRQ to the 'sh_eth' driver from
the platform code and removes now useless code that hinders the PHY IRQ handing
by philib.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Dec 20, 2013
2 parents 9ddffb8 + 4174ecd commit 4742e78
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
11 changes: 4 additions & 7 deletions drivers/net/ethernet/renesas/sh_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -1685,8 +1685,8 @@ static int sh_eth_phy_init(struct net_device *ndev)
return PTR_ERR(phydev);
}

dev_info(&ndev->dev, "attached phy %i to driver %s\n",
phydev->addr, phydev->drv->name);
dev_info(&ndev->dev, "attached PHY %d (IRQ %d) to driver %s\n",
phydev->addr, phydev->irq, phydev->drv->name);

mdp->phydev = phydev;

Expand All @@ -1703,11 +1703,6 @@ static int sh_eth_phy_start(struct net_device *ndev)
if (ret)
return ret;

/* reset phy - this also wakes it from PDOWN */
ret = phy_init_hw(mdp->phydev);
if (ret)
return ret;

phy_start(mdp->phydev);

return 0;
Expand Down Expand Up @@ -2544,6 +2539,8 @@ static int sh_mdio_init(struct net_device *ndev, int id,

for (i = 0; i < PHY_MAX_ADDR; i++)
mdp->mii_bus->irq[i] = PHY_POLL;
if (pd->phy_irq > 0)
mdp->mii_bus->irq[pd->phy] = pd->phy_irq;

/* register mdio bus */
ret = mdiobus_register(mdp->mii_bus);
Expand Down
1 change: 1 addition & 0 deletions include/linux/sh_eth.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ enum {EDMAC_LITTLE_ENDIAN, EDMAC_BIG_ENDIAN};

struct sh_eth_plat_data {
int phy;
int phy_irq;
int edmac_endian;
phy_interface_t phy_interface;
void (*set_mdio_gate)(void *addr);
Expand Down

0 comments on commit 4742e78

Please sign in to comment.