Skip to content

Commit

Permalink
mac80211: Fix handling of retry count of NO_ACK frames in minstrel
Browse files Browse the repository at this point in the history
Make the retry count zero (total try count = 1) for frames with
IEEE80211_TX_CTL_NO_ACK set.

Also remove the check for is_multicast_ether_addr in use_low_rate,
which is redundant because all multicasts have IEEE80211_TX_CTL_NO_ACK
set.

Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Gábor Stefanik authored and John W. Linville committed May 6, 2009
1 parent 2516baa commit 4edf040
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions net/mac80211/rc80211_minstrel.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@ use_low_rate(struct sk_buff *skb)
fc = le16_to_cpu(hdr->frame_control);

return ((info->flags & IEEE80211_TX_CTL_NO_ACK) ||
(fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA ||
is_multicast_ether_addr(hdr->addr1));
(fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA);
}


Expand Down Expand Up @@ -245,7 +244,10 @@ minstrel_get_rate(void *priv, struct ieee80211_sta *sta,

if (!sta || !mi || use_low_rate(skb)) {
ar[0].idx = rate_lowest_index(sband, sta);
ar[0].count = mp->max_retry;
if (info->flags & IEEE80211_TX_CTL_NO_ACK)
ar[0].count = 1;
else
ar[0].count = mp->max_retry;
return;
}

Expand Down

0 comments on commit 4edf040

Please sign in to comment.