Skip to content

Commit

Permalink
ext2: remove unnecessary dentry_unhash on rmdir/rename_dir
Browse files Browse the repository at this point in the history
ext2 has no problems with lingering references to unlinked directory
inodes.

CC: Jan Kara <jack@suse.cz>
CC: linux-ext4@vger.kernel.org
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Sage Weil authored and Al Viro committed May 26, 2011
1 parent 5a61a24 commit 5afcb94
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions fs/ext2/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,6 @@ static int ext2_rmdir (struct inode * dir, struct dentry *dentry)
struct inode * inode = dentry->d_inode;
int err = -ENOTEMPTY;

dentry_unhash(dentry);

if (ext2_empty_dir(inode)) {
err = ext2_unlink(dir, dentry);
if (!err) {
Expand All @@ -320,9 +318,6 @@ static int ext2_rename (struct inode * old_dir, struct dentry * old_dentry,
struct ext2_dir_entry_2 * old_de;
int err = -ENOENT;

if (new_dentry->d_inode && S_ISDIR(new_dentry->d_inode->i_mode))
dentry_unhash(new_dentry);

dquot_initialize(old_dir);
dquot_initialize(new_dir);

Expand Down

0 comments on commit 5afcb94

Please sign in to comment.