Skip to content

Commit

Permalink
RxRPC: Use kmemdup rather than duplicating its implementation
Browse files Browse the repository at this point in the history
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Thomas Meyer authored and David S. Miller committed Nov 21, 2011
1 parent cb50870 commit 65d9d2c
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions net/rxrpc/ar-key.c
Original file line number Diff line number Diff line change
Expand Up @@ -306,10 +306,9 @@ static int rxrpc_krb5_decode_tagged_data(struct krb5_tagged_data *td,
td->data_len = len;

if (len > 0) {
td->data = kmalloc(len, GFP_KERNEL);
td->data = kmemdup(xdr, len, GFP_KERNEL);
if (!td->data)
return -ENOMEM;
memcpy(td->data, xdr, len);
len = (len + 3) & ~3;
toklen -= len;
xdr += len >> 2;
Expand Down Expand Up @@ -401,10 +400,9 @@ static int rxrpc_krb5_decode_ticket(u8 **_ticket, u16 *_tktlen,
_debug("ticket len %u", len);

if (len > 0) {
*_ticket = kmalloc(len, GFP_KERNEL);
*_ticket = kmemdup(xdr, len, GFP_KERNEL);
if (!*_ticket)
return -ENOMEM;
memcpy(*_ticket, xdr, len);
len = (len + 3) & ~3;
toklen -= len;
xdr += len >> 2;
Expand Down

0 comments on commit 65d9d2c

Please sign in to comment.