Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 376535
b: refs/heads/master
c: cbda6aa
h: refs/heads/master
i:
  376533: 37b3131
  376531: dabb480
  376527: 71b5767
v: v3
  • Loading branch information
Michael Ellerman authored and Benjamin Herrenschmidt committed May 31, 2013
1 parent 218173d commit 678137e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 25 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 858957ab1e3a7ee29ed40309bdf0f1b7bcf5bf30
refs/heads/master: cbda6aa10bd2d97e38f4d26a03a0b2183ad580ba
30 changes: 6 additions & 24 deletions trunk/arch/powerpc/perf/core-book3s.c
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ static inline void power_pmu_bhrb_read(struct cpu_hw_events *cpuhw) {}

static bool regs_use_siar(struct pt_regs *regs)
{
return !!(regs->result & 1);
return !!regs->result;
}

/*
Expand Down Expand Up @@ -181,11 +181,6 @@ static bool regs_sipr(struct pt_regs *regs)
return !!(regs->dsisr & sipr);
}

static bool regs_no_sipr(struct pt_regs *regs)
{
return !!(regs->result & 2);
}

static inline u32 perf_flags_from_msr(struct pt_regs *regs)
{
if (regs->msr & MSR_PR)
Expand All @@ -208,7 +203,7 @@ static inline u32 perf_get_misc_flags(struct pt_regs *regs)
* SIAR which should give slightly more reliable
* results
*/
if (regs_no_sipr(regs)) {
if (ppmu->flags & PPMU_NO_SIPR) {
unsigned long siar = mfspr(SPRN_SIAR);
if (siar >= PAGE_OFFSET)
return PERF_RECORD_MISC_KERNEL;
Expand Down Expand Up @@ -239,22 +234,9 @@ static inline void perf_read_regs(struct pt_regs *regs)
int use_siar;

regs->dsisr = mmcra;
regs->result = 0;

if (ppmu->flags & PPMU_NO_SIPR)
regs->result |= 2;

/*
* On power8 if we're in random sampling mode, the SIER is updated.
* If we're in continuous sampling mode, we don't have SIPR.
*/
if (ppmu->flags & PPMU_HAS_SIER) {
if (marked)
regs->dar = mfspr(SPRN_SIER);
else
regs->result |= 2;
}

if (ppmu->flags & PPMU_HAS_SIER)
regs->dar = mfspr(SPRN_SIER);

/*
* If this isn't a PMU exception (eg a software event) the SIAR is
Expand All @@ -279,12 +261,12 @@ static inline void perf_read_regs(struct pt_regs *regs)
use_siar = 1;
else if ((ppmu->flags & PPMU_NO_CONT_SAMPLING))
use_siar = 0;
else if (!regs_no_sipr(regs) && regs_sipr(regs))
else if (!(ppmu->flags & PPMU_NO_SIPR) && regs_sipr(regs))
use_siar = 0;
else
use_siar = 1;

regs->result |= use_siar;
regs->result = use_siar;
}

/*
Expand Down

0 comments on commit 678137e

Please sign in to comment.