---

yaml --- r: 208271 b: refs/heads/master c: f10d9f6 h: refs/heads/master i: 208269: 815e2c8 208267: b49e44d 208263: ae77c21 208255: 5a6b796 v: v3
git-mirror · Aug 7, 2010 · 67be290 · 67be290
1 parent 50960b4
commit 67be290
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 2669b19fa4debcdd6a660ace1a124c0900f113e6
+refs/heads/master: f10d9f617a65905c556c3b37c9b9646ae7d04ed7
diff --git a/trunk/block/blk-barrier.c b/trunk/block/blk-barrier.c
@@ -310,6 +310,15 @@ int blkdev_issue_flush(struct block_device *bdev, gfp_t gfp_mask,
 	if (!q)
 		return -ENXIO;
 
+	/*
+	 * some block devices may not have their queue correctly set up here
+	 * (e.g. loop device without a backing file) and so issuing a flush
+	 * here will panic. Ensure there is a request function before issuing
+	 * the barrier.
+	 */
+	if (!q->make_request_fn)
+		return -ENXIO;
+
 	bio = bio_alloc(gfp_mask, 0);
 	bio->bi_end_io = bio_end_empty_barrier;
 	bio->bi_bdev = bdev;