Skip to content

Commit

Permalink
net/ariadne: delete unneeded call to netdev_priv
Browse files Browse the repository at this point in the history
Netdev_priv is an accessor function, and has no purpose if its result is
not used.

A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@ local idexpression x; @@
-x = netdev_priv(...);
... when != x
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julia Lawall authored and David S. Miller committed May 15, 2014
1 parent 7077f22 commit 688c3b0
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/net/ethernet/amd/ariadne.c
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,6 @@ static int ariadne_init_one(struct zorro_dev *z,
unsigned long mem_start = board + ARIADNE_RAM;
struct resource *r1, *r2;
struct net_device *dev;
struct ariadne_private *priv;
u32 serial;
int err;

Expand All @@ -738,8 +737,6 @@ static int ariadne_init_one(struct zorro_dev *z,
return -ENOMEM;
}

priv = netdev_priv(dev);

r1->name = dev->name;
r2->name = dev->name;

Expand Down

0 comments on commit 688c3b0

Please sign in to comment.