Skip to content

Commit

Permalink
leds-lp5523: change the return type of lp5523_set_mode()
Browse files Browse the repository at this point in the history
The return value of this function is not handled any place, so
make it as void type.

And three if-statements are replaced with switch-statements.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
  • Loading branch information
Kim, Milo authored and Bryan Wu committed Sep 11, 2012
1 parent a39b985 commit 6f6365f
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions drivers/leds/leds-lp5523.c
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ static inline struct lp5523_chip *led_to_lp5523(struct lp5523_led *led)
leds[led->id]);
}

static int lp5523_set_mode(struct lp5523_engine *engine, u8 mode);
static void lp5523_set_mode(struct lp5523_engine *engine, u8 mode);
static int lp5523_set_engine_mode(struct lp5523_engine *engine, u8 mode);
static int lp5523_load_program(struct lp5523_engine *engine, const u8 *pattern);

Expand Down Expand Up @@ -789,26 +789,28 @@ static void lp5523_unregister_sysfs(struct i2c_client *client)
/*--------------------------------------------------------------*/
/* Set chip operating mode */
/*--------------------------------------------------------------*/
static int lp5523_set_mode(struct lp5523_engine *engine, u8 mode)
static void lp5523_set_mode(struct lp5523_engine *engine, u8 mode)
{
int ret = 0;

/* if in that mode already do nothing, except for run */
if (mode == engine->mode && mode != LP5523_CMD_RUN)
return 0;
return;

if (mode == LP5523_CMD_RUN) {
ret = lp5523_run_program(engine);
} else if (mode == LP5523_CMD_LOAD) {
switch (mode) {
case LP5523_CMD_RUN:
lp5523_run_program(engine);
break;
case LP5523_CMD_LOAD:
lp5523_set_engine_mode(engine, LP5523_CMD_DISABLED);
lp5523_set_engine_mode(engine, LP5523_CMD_LOAD);
} else if (mode == LP5523_CMD_DISABLED) {
break;
case LP5523_CMD_DISABLED:
lp5523_set_engine_mode(engine, LP5523_CMD_DISABLED);
break;
default:
return;
}

engine->mode = mode;

return ret;
}

/*--------------------------------------------------------------*/
Expand Down

0 comments on commit 6f6365f

Please sign in to comment.