Skip to content

Commit

Permalink
[PATCH] acenic: fix checking of read_eeprom_byte() return values
Browse files Browse the repository at this point in the history
tmp in ace_init is u32 thus rendering read_eeprom_byte() return values
checks useless.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
  • Loading branch information
Eric Sesterhenn authored and Jeff Garzik committed Jan 27, 2006
1 parent 6a986ce commit 6f9d472
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/net/acenic.c
Original file line number Diff line number Diff line change
Expand Up @@ -1002,6 +1002,8 @@ static int __devinit ace_init(struct net_device *dev)

mac1 = 0;
for(i = 0; i < 4; i++) {
int tmp;

mac1 = mac1 << 8;
tmp = read_eeprom_byte(dev, 0x8c+i);
if (tmp < 0) {
Expand All @@ -1012,6 +1014,8 @@ static int __devinit ace_init(struct net_device *dev)
}
mac2 = 0;
for(i = 4; i < 8; i++) {
int tmp;

mac2 = mac2 << 8;
tmp = read_eeprom_byte(dev, 0x8c+i);
if (tmp < 0) {
Expand Down

0 comments on commit 6f9d472

Please sign in to comment.