Skip to content

Commit

Permalink
Staging: hv: remove PFN_CHANNEL_CALLBACK
Browse files Browse the repository at this point in the history
Come on people, it doesn't get simpler than this, why
have a typedef for something so tiny...

Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Sep 15, 2009
1 parent f25c749 commit 7903506
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions drivers/staging/hv/Channel.c
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ void VmbusChannelGetDebugInfo(struct vmbus_channel *Channel,
*/
int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 SendRingBufferSize,
u32 RecvRingBufferSize, void *UserData, u32 UserDataLen,
PFN_CHANNEL_CALLBACK pfnOnChannelCallback, void *Context)
void (*OnChannelCallback)(void *context), void *Context)
{
struct vmbus_channel_open_channel *openMsg;
struct vmbus_channel_msginfo *openInfo;
Expand All @@ -183,7 +183,7 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 SendRingBufferSize,
ASSERT(!(SendRingBufferSize & (PAGE_SIZE - 1)));
ASSERT(!(RecvRingBufferSize & (PAGE_SIZE - 1)));

NewChannel->OnChannelCallback = pfnOnChannelCallback;
NewChannel->OnChannelCallback = OnChannelCallback;
NewChannel->ChannelCallbackContext = Context;

/* Allocate the ring buffer */
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/hv/Channel.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ extern int VmbusChannelOpen(struct vmbus_channel *channel,
u32 RecvRingBufferSize,
void *UserData,
u32 UserDataLen,
PFN_CHANNEL_CALLBACK pfnOnChannelCallback,
void(*OnChannelCallback)(void *context),
void *Context);

extern void VmbusChannelClose(struct vmbus_channel *channel);
Expand Down
4 changes: 1 addition & 3 deletions drivers/staging/hv/ChannelMgmt.h
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,6 @@ struct vmbus_channel_version_response {
bool VersionSupported;
} __attribute__((packed));

typedef void (*PFN_CHANNEL_CALLBACK)(void *context);

enum vmbus_channel_state {
CHANNEL_OFFER_STATE,
CHANNEL_OPENING_STATE,
Expand Down Expand Up @@ -256,7 +254,7 @@ struct vmbus_channel {
/* Channel callback are invoked in this workqueue context */
/* HANDLE dataWorkQueue; */

PFN_CHANNEL_CALLBACK OnChannelCallback;
void (*OnChannelCallback)(void *context);
void *ChannelCallbackContext;
};

Expand Down

0 comments on commit 7903506

Please sign in to comment.