Skip to content

Commit

Permalink
padata: Remove superfluous might_sleep
Browse files Browse the repository at this point in the history
might_sleep() was placed before mutex_lock() in some places.
We remove them because mutex_lock() does might_sleep() too.

Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Steffen Klassert authored and Herbert Xu committed May 3, 2010
1 parent e2cb2f1 commit 7d0d2d3
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions kernel/padata.c
Original file line number Diff line number Diff line change
Expand Up @@ -443,8 +443,6 @@ int padata_set_cpumask(struct padata_instance *pinst,
struct parallel_data *pd;
int err = 0;

might_sleep();

mutex_lock(&pinst->lock);

pd = padata_alloc_pd(pinst, cpumask);
Expand Down Expand Up @@ -489,8 +487,6 @@ int padata_add_cpu(struct padata_instance *pinst, int cpu)
{
int err;

might_sleep();

mutex_lock(&pinst->lock);

cpumask_set_cpu(cpu, pinst->cpumask);
Expand Down Expand Up @@ -527,8 +523,6 @@ int padata_remove_cpu(struct padata_instance *pinst, int cpu)
{
int err;

might_sleep();

mutex_lock(&pinst->lock);

cpumask_clear_cpu(cpu, pinst->cpumask);
Expand All @@ -547,8 +541,6 @@ EXPORT_SYMBOL(padata_remove_cpu);
*/
void padata_start(struct padata_instance *pinst)
{
might_sleep();

mutex_lock(&pinst->lock);
pinst->flags |= PADATA_INIT;
mutex_unlock(&pinst->lock);
Expand All @@ -562,8 +554,6 @@ EXPORT_SYMBOL(padata_start);
*/
void padata_stop(struct padata_instance *pinst)
{
might_sleep();

mutex_lock(&pinst->lock);
pinst->flags &= ~PADATA_INIT;
mutex_unlock(&pinst->lock);
Expand Down

0 comments on commit 7d0d2d3

Please sign in to comment.