Skip to content

Commit

Permalink
virtio_blk: change to use __blk_end_request()
Browse files Browse the repository at this point in the history
This patch converts virtio_blk to use __blk_end_request() directly
so that end_{queued|dequeued}_request() can be removed.
Related 'uptodate' argument is converted to 'error'.

Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Kiyoshi Ueda authored and Jens Axboe committed Oct 9, 2008
1 parent 0497b34 commit 8316982
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/block/virtio_blk.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,20 +47,20 @@ static void blk_done(struct virtqueue *vq)

spin_lock_irqsave(&vblk->lock, flags);
while ((vbr = vblk->vq->vq_ops->get_buf(vblk->vq, &len)) != NULL) {
int uptodate;
int error;
switch (vbr->status) {
case VIRTIO_BLK_S_OK:
uptodate = 1;
error = 0;
break;
case VIRTIO_BLK_S_UNSUPP:
uptodate = -ENOTTY;
error = -ENOTTY;
break;
default:
uptodate = 0;
error = -EIO;
break;
}

end_dequeued_request(vbr->req, uptodate);
__blk_end_request(vbr->req, error, blk_rq_bytes(vbr->req));
list_del(&vbr->list);
mempool_free(vbr, vblk->pool);
}
Expand Down

0 comments on commit 8316982

Please sign in to comment.